Skip to content

2236 Fix the duplicated key issue in CopyItemsd transform #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nic-Ma merged 6 commits into from
May 24, 2021
Merged

2236 Fix the duplicated key issue in CopyItemsd transform #2238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
42a45e0
Merge pull request #19 from Project-MONAI/master
Nic-Ma Feb 1, 2021
cd16a13
Merge pull request #32 from Project-MONAI/master
Nic-Ma Feb 24, 2021
62bd0c9
Merge pull request #112 from Project-MONAI/dev
Nic-Ma May 24, 2021
5d8c252
[DLMED] fix CopyItemsd transform
Nic-Ma May 24, 2021
c50e300
Merge branch 'dev' into 2236-fix-copyitemsd
Nic-Ma May 24, 2021
a379b64
[MONAI] python code formatting
monai-bot May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions monai/transforms/utility/dictionary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,10 +730,11 @@ def __call__(self, data):

"""
d = dict(data)
for new_key in self.names:
if new_key in d:
raise KeyError(f"Key {new_key} already exists in data.")
for key in self.key_iterator(d):
key_len = len(self.keys)
for i in range(self.times):
for key, new_key in self.key_iterator(d, self.names[i * key_len : (i + 1) * key_len]):
if new_key in d:
raise KeyError(f"Key {new_key} already exists in data.")
if isinstance(d[key], torch.Tensor):
d[new_key] = d[key].detach().clone()
else:
Expand Down
6 changes: 3 additions & 3 deletions tests/test_copy_itemsd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@
class TestCopyItemsd(unittest.TestCase):
@parameterized.expand([TEST_CASE_1, TEST_CASE_2, TEST_CASE_3, TEST_CASE_4])
def test_numpy_values(self, keys, times, names):
input_data = {"img": np.array([[0, 1], [1, 2]]), "seg": np.array([[0, 1], [1, 2]])}
input_data = {"img": np.array([[0, 1], [1, 2]]), "seg": np.array([[3, 4], [4, 5]])}
result = CopyItemsd(keys=keys, times=times, names=names)(input_data)
for name in ensure_tuple(names):
self.assertTrue(name in result)
result[name] += 1
np.testing.assert_allclose(result[name], np.array([[1, 2], [2, 3]]))
result["img_1"] += 1
np.testing.assert_allclose(result["img_1"], np.array([[1, 2], [2, 3]]))
np.testing.assert_allclose(result["img"], np.array([[0, 1], [1, 2]]))

def test_tensor_values(self):
Expand Down