197 set up versioneer and test releasing #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
changed the title
Nic-Ma
reviewed
Mar 29, 2020
Nic-Ma
reviewed
Mar 29, 2020
Nic-Ma
reviewed
Mar 29, 2020
Nic-Ma
reviewed
Mar 29, 2020
wyli
force-pushed
the
197-set-up-versioneer
branch
3 times, most recently
from
0bca1e8 to
f0ad0d5
Compare
- tests for python 3.x
- adds license for setup.py
- adds python3.x required in setup.cfg
wyli
force-pushed
the
197-set-up-versioneer
branch
from
f0ad0d5 to
4087626
Compare
Nic-Ma
approved these changes
Mar 30, 2020
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me now.
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197.
Description
so that
python -c 'import monai; print(monai.__version__)'returns a PEP440 versioningsetup.cfgcontributing.mdTesting
To test the correctness, I've tagged a commit of this branch with version number
0.1a1.dev1:python -c 'import monai; print(monai.__version__)'returned the correct version number. this was tested from multiple cases:
the version number becomes
0.1a1.dev1+1.ge6de7ac. Which is expected. the number indicates 1 revision ahead of0.1a1.dev1with hash e6de7ac.Things not covered
the
CONTRIBUTING.mdnow covers the building/releasing procedure,automating the procedure will need another iteration
Status
READY
Types of changes