Skip to content

2479 - enhance version compare #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 11 commits into from
Jun 30, 2021
Merged

2479 - enhance version compare #2485

wyli merged 11 commits into from
Jun 30, 2021

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jun 29, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Description

  • update to prefer pkg_resources if it's installed
  • move version_leq to utils.module
  • fixes an issue the following code doesn't throw errors:
from monai.utils.deprecated import deprecated
deprecated(since="0.6", removed="0.8", version_val="0.9")(lambda x: x)(1)
  • add tests

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits June 29, 2021 20:06
@wyli
enhance version compare
1d22f52 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
15416b9 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro June 29, 2021 20:54
wyli
wyli commented Jun 29, 2021
View reviewed changes
wyli
wyli commented Jun 29, 2021
View reviewed changes
wyli added 2 commits June 29, 2021 21:58
@wyli
remove unused
b67214b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove unused vars
2a5d54a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the update-version-cmp branch from fa9a634 to 2a5d54a Compare June 29, 2021 21:47
@Nic-Ma Nic-Ma mentioned this pull request Jun 30, 2021
Merged
7 tasks
wyli added 6 commits June 30, 2021 10:14
@wyli
update debug info
1f87607 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
597adb3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
non integer comparison
f6c19e9 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds tests
d462b17 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
no temp tests
e178b05 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update test
8418581 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
Nic-Ma approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@ericspod could you please help double confirm it?

Thanks.

@wyli wyli merged commit 25578e3 into Project-MONAI:dev Jun 30, 2021
@wyli wyli deleted the update-version-cmp branch June 30, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyli @ericspod @Nic-Ma