Skip to content

2635 Enhance doc-string of UNet for spatial size #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nic-Ma merged 11 commits into from
Jul 26, 2021
Merged

2635 Enhance doc-string of UNet for spatial size #2641

Nic-Ma merged 11 commits into from
Jul 26, 2021
+91 −8

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 22, 2021 •
edited
Loading

Fixes #2635 .

Description

As several users asked questions about the input size of UNet, this PR enhanced the doc-string to make it clear.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 22, 2021

/black

yiheng-wang-nv
yiheng-wang-nv reviewed Jul 22, 2021
View reviewed changes
@Nic-Ma
[DLMED] add ill test case
9908705 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 22, 2021

/black

@Nic-Ma
[DLMED] update test error
521867d 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 22, 2021

/black

@Nic-Ma Nic-Ma requested a review from yiheng-wang-nv July 22, 2021 08:29
wyli
wyli reviewed Jul 22, 2021
View reviewed changes
@Nic-Ma Nic-Ma changed the title 2635 Enhance doc-string of UNet for spatial size [WIP] 2635 Enhance doc-string of UNet for spatial size Jul 23, 2021
@yiheng-wang-nv
Copy link
Contributor

yiheng-wang-nv commented Jul 23, 2021

Supplement: test_unet.py does not cover the parameters: kernel_size and up_kernel_size, and strides is always (2, 2). I think more test cases are necessary.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 23, 2021

Supplement: test_unet.py does not cover the parameters: kernel_size and up_kernel_size, and strides is always (2, 2). I think more test cases are necessary.

Sure, please feel free to submit commits directly.

Thanks.

wyli
wyli reviewed Jul 26, 2021
View reviewed changes
@Nic-Ma
[DLMED] add link to doc-string
292138e 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 26, 2021

/black

@Nic-Ma
[DLMED] enhance doc-string
217b9c1 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 2635 Enhance doc-string of UNet for spatial size 2635 Enhance doc-string of UNet for spatial size Jul 26, 2021
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 26, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 26, 2021 15:49
@monai-bot
[MONAI] python code formatting
6a00bce 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma Nic-Ma merged commit 141e9db into Project-MONAI:dev Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nic-Ma @yiheng-wang-nv @wyli @monai-bot