Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 27, 2021

part of #2648 .

Description

This PR added the LongestRescale and LongestRescaled transforms, inspired by the albumentations API.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 11 commits February 1, 2021 19:15
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

/black

@Nic-Ma Nic-Ma changed the title [WIP] 2648 Add LongestRescale transform 2648 Add LongestRescale transform Jul 28, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 28, 2021 13:00
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 28, 2021 13:02
@wyli
Copy link
Contributor

wyli commented Jul 28, 2021

I think there's a large overlap between this and Resize, Resize also supports int as the spatial_size. would be nice to merge this into Resize, and provide a flexible size_mode for Resize. maybe in the future with different size_mode, we'll have different interpretation for cases such as spatial_size=32 and spatial_size=(32, -1, -1)

Signed-off-by: Nic Ma <nma@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick updates

Nic-Ma added 6 commits July 28, 2021 23:19
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 28, 2021 15:42
@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

1 similar comment
@madil90
Copy link
Contributor

madil90 commented Jul 28, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 28, 2021

Hi @madil90 ,

May I know why the blossom CI failed? I tried to re-run it, but it still fails.

Thanks in advance.

@Nic-Ma Nic-Ma merged commit d8613b2 into Project-MONAI:dev Jul 29, 2021
wyli pushed a commit to wyli/MONAI that referenced this pull request Aug 3, 2021
* [DLMED] init the transform

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update doc-string

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] complete array transform

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add unit tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add dict transform and inverse tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix mypy type

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] change to enhance Resize transform

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix CI tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix TTA

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] remove tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix mypy error

Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants