Skip to content

Conversation

@tvercaut
Copy link
Member

@tvercaut tvercaut commented Aug 3, 2021

This is to address an issue in the bibtex conversion.

Signed-off-by: Tom Vercauteren tom.vercauteren@kcl.ac.uk

Description

The current CFF files leads to a suboptimal bibtex output. This fixes will not directly change the bibtex output but it will be the case once
citation-file-format/ruby-cff#63
is fixed and the change is rolled out to GitHub.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

This is to address an issue in the bibtex conversion.

Signed-off-by: Tom Vercauteren <tom.vercauteren@kcl.ac.uk>
@tvercaut tvercaut requested a review from wyli August 3, 2021 07:46
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 9ecb0e1 into Project-MONAI:dev Aug 3, 2021
wyli pushed a commit to wyli/MONAI that referenced this pull request Aug 3, 2021
This is to address an issue in the bibtex conversion.

Signed-off-by: Tom Vercauteren <tom.vercauteren@kcl.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants