Remove unnecessary use of comprehension #2719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
…tatement (#2717) * Refactor unnecessary `else` / `elif` when `if` block has a `return` statement * Unnecessary `else`/`elif` used after `raise` PYL-R1720 Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
* Replace ternary syntax with if expression * fixes Duplicate dictionary keys PYL-W0109 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * remove Unused variable data_ Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
approved these changes
Aug 7, 2021
Contributor
There was a problem hiding this comment.
this is almost an automatic fix, added "self.scaler" to 'monai/engines/workflow.py' otherwise this line is a property definition out of the class constructor
MONAI/monai/engines/trainer.py
Line 55 in 945e21c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.