-
Notifications
You must be signed in to change notification settings - Fork 1.4k
NVTX Range Transform #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVTX Range Transform #2756
Conversation
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Nic-Ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@wyli what do you think?
Thanks.
|
@wyli, if you don't have any comment on this, I'll merge the PR. Please let me know. Thanks. |
|
thanks @drbeh, I have a quick question, what will happen if we have the same |
If we are profiling the same transform that is used multiple times in the compose, like |
Fixes #2754
Description
This PR adds Range transform which accept a transform as an input and pushes an NVTX range before that transform, and pops it afterwards.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.