2901 ndim -> spatial_dims

[wyli]

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #2901

Description

• deprecate ndim
• enhance deprecated_arg

Status

ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

Hi @wyli ,

Thanks for your quick update.
I want to confirm the expected behavior: It will print deprecated warning at 0.7? And will print error at 0.8?

Thanks.

[wyli]

Hi @wyli ,

Thanks for your quick update.
I want to confirm the expected behavior: It will print deprecated warning at 0.7? And will print error at 0.8?

Thanks.

It will only print warnings in the current implementation. we'll need another PR to remove the parameters when we decide they are no longer supported. I think we can remove the deprecated APIs before 1.0.

[Nic-Ma]

Looks good to me.
@yiheng-wang-nv Could you please help double confirm all the network updating tomorrow before merging it?

Thanks in advance.

[wyli]

/build

[wyli]

/integration-test