Skip to content

2951 Optimize type_conversion logic #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 9 commits into from
Sep 15, 2021
Merged

2951 Optimize type_conversion logic #2955

wyli merged 9 commits into from
Sep 15, 2021

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 15, 2021 •
edited
Loading

Fixes #2951 .

Description

This PR optimized the type_conversion logic based on user feedback for better performance.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the 2951-optimize-convert-type branch from a1ed832 to bab919c Compare September 15, 2021 16:24
@Nic-Ma
[DLMED] fix CI test
2b59773 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add more unit tests
08c9aa4 
Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Sep 15, 2021

/build

@Nic-Ma
[DLMED] fix flake8
c7d609d 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 2951 Optimize type_conversion logic 2951 Optimize type_conversion logic Sep 15, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review September 15, 2021 17:23
wyli
wyli approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, will have more integration tests with this

@wyli wyli enabled auto-merge (squash) September 15, 2021 18:36
@wyli wyli merged commit 2f4b582 into Project-MONAI:dev Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@bhashemian bhashemian Awaiting requested review from bhashemian

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add kwargs to ToTensor, ToNumpy and ToCupy

2 participants

@Nic-Ma @wyli