Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 16, 2021

Fixes #2959 .

Description

This PR fixed the float64 issue in Rotate transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nic-Ma , here could other transforms have the same issue?

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 16, 2021

Hi @Nic-Ma , here could other transforms have the same issue?

Hi @yiheng-wang-nv ,

I checked all the other spatial transforms, seems no other similar issue.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 16, 2021 02:39
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 16, 2021

/integration-test

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 16, 2021

We should always output float32 in Rotate transform as the doc-string said:
https://github.com/Project-MONAI/MONAI/blob/0.7.0rc1/monai/transforms/spatial/array.py#L445

Thanks.

@Nic-Ma Nic-Ma merged commit fb2c2e9 into Project-MONAI:dev Sep 16, 2021
@wyli
Copy link
Contributor

wyli commented Sep 16, 2021

thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration error -- IntegrationClassification2D

3 participants