Skip to content

Conversation

@ahatamiz
Copy link
Contributor

Signed-off-by: ahatamizadeh ahatamizadeh@nvidia.com

Description

This PR updates the doc for multi-modal transformers by adding proper paper reference and updating the model name.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz requested a review from wyli September 19, 2021 16:21
@ahatamiz ahatamiz self-assigned this Sep 19, 2021
@ahatamiz ahatamiz added the enhancement New feature or request label Sep 19, 2021
@ahatamiz ahatamiz added this to the Multi Modality Support milestone Sep 19, 2021
@ahatamiz ahatamiz changed the title update multimodl doc and model names (Transchex) update multimodal doc and model names (Transchex) Sep 19, 2021
@ahatamiz
Copy link
Contributor Author

/black

@ahatamiz
Copy link
Contributor Author

/build

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz
Copy link
Contributor Author

/black

@ahatamiz
Copy link
Contributor Author

/build

@ahatamiz
Copy link
Contributor Author

Hi @wyli I have added the paper reference and improved the docs for this PR.

Thanks

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz
Copy link
Contributor Author

/black

@ahatamiz
Copy link
Contributor Author

/build

Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz
Copy link
Contributor Author

/black

@ahatamiz
Copy link
Contributor Author

/build

@ahatamiz ahatamiz requested a review from Nic-Ma September 19, 2021 19:52
@ahatamiz
Copy link
Contributor Author

/black

@ahatamiz
Copy link
Contributor Author

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me

@ahatamiz ahatamiz removed the request for review from Nic-Ma September 20, 2021 15:30
@wyli wyli enabled auto-merge (squash) September 20, 2021 16:07
@wyli wyli merged commit 731bad8 into Project-MONAI:dev Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants