Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Oct 22, 2021

Fixes #3172 .

Description

This PR implemented utility to save model as TorchScript model with optional verification.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 22, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 22, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 22, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 22, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 22, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 23, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 23, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Oct 23, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 24, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 24, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 3172-add-torchscript branch from dbebfda to 7fd5258 Compare October 24, 2021 01:18
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 24, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 24, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 24, 2021

/build

@Nic-Ma Nic-Ma force-pushed the 3172-add-torchscript branch from f9598b4 to 727b343 Compare October 24, 2021 02:41
@Nic-Ma Nic-Ma requested a review from ericspod October 25, 2021 08:29
@Nic-Ma Nic-Ma enabled auto-merge (squash) October 25, 2021 08:30
@wyli
Copy link
Contributor

wyli commented Oct 25, 2021

/build

@Nic-Ma Nic-Ma merged commit 9084c45 into Project-MONAI:dev Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add utility to save model into TorchScript model

3 participants