Skip to content

Conversation

@finalelement
Copy link
Collaborator

@finalelement finalelement commented Oct 26, 2021

Description

This PR is for adding a modified version of the ViT architecture for the reason because the ViT does not give the same sized output as the input. The proposed architecture allows for the flexibility to reconstruct the same size output as that of the input size

Status

This is work in progress, do not merge yet.

Integration tests need to be commented upon
Doc strings & Documentation also needs to be updated

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR.
I put some minor comments in it.
@wyli @ericspod Could you please help also review it?

Thanks.

@wyli
Copy link
Contributor

wyli commented Oct 27, 2021

Hi @ahatamiz, could you please help review the implementation? thanks!

Copy link
Contributor

@ahatamiz ahatamiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ahatamiz, could you please help review the implementation? thanks!

Hi @wyli

I have reviewed and added my comments. The implementation is mostly good but need to remove anything about classification.

Thanks,

Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
@finalelement finalelement force-pushed the vit_ae branch 2 times, most recently from 1e19278 to 8490241 Compare November 1, 2021 15:40
Signed-off-by: vnath <vnath@nvidia.com>
@finalelement
Copy link
Collaborator Author

@wyli @Nic-Ma all comments have been addressed apart from the variable naming. All tests pass, there is something going on in the croppad transform which to which I made no changes at all. I also tried pulling the latest, but this one ./runtests.sh --codeformat fails for the array.py in croppad transforms.

Please let me know if there are any more things to address from my side, otherwise lets merge and close this off

… 2D inputs

Signed-off-by: vnath <vnath@nvidia.com>
…ard comptability

Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Nov 2, 2021

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) November 2, 2021 20:27
@wyli wyli merged commit 4c7a187 into Project-MONAI:dev Nov 2, 2021
@wyli wyli mentioned this pull request Nov 30, 2021
7 tasks
@finalelement finalelement deleted the vit_ae branch May 13, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants