-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adding ViT Autoencoder #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ViT Autoencoder #3194
Conversation
Nic-Ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi @ahatamiz, could you please help review the implementation? thanks! |
ahatamiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
1e19278 to
8490241
Compare
Signed-off-by: vnath <vnath@nvidia.com>
|
@wyli @Nic-Ma all comments have been addressed apart from the variable naming. All tests pass, there is something going on in the croppad transform which to which I made no changes at all. I also tried pulling the latest, but this one ./runtests.sh --codeformat fails for the array.py in croppad transforms. Please let me know if there are any more things to address from my side, otherwise lets merge and close this off |
… 2D inputs Signed-off-by: vnath <vnath@nvidia.com>
…ard comptability Signed-off-by: vnath <vnath@nvidia.com>
Signed-off-by: vnath <vnath@nvidia.com>
for more information, see https://pre-commit.ci
|
/build |
wyli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
Description
This PR is for adding a modified version of the ViT architecture for the reason because the ViT does not give the same sized output as the input. The proposed architecture allows for the flexibility to reconstruct the same size output as that of the input size
Status
This is work in progress, do not merge yet.
Integration tests need to be commented upon
Doc strings & Documentation also needs to be updated
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.