3161 Skip reader registration if the dependency package not installed #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Nic-Ma
force-pushed
the
3161-fix-loadimage-msg
branch
from
b910067 to
65be3ad
Compare
Contributor
Author
|
/build |
Nic-Ma
force-pushed
the
3161-fix-loadimage-msg
branch
from
65be3ad to
af99c79
Compare
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
3161-fix-loadimage-msg
branch
from
af99c79 to
7d9375f
Compare
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
reviewed
Oct 31, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
|
/build |
wyli
approved these changes
Oct 31, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3161 .
Description
This PR skips reader registration in LoadImage if the dependency package is not installed.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.