Skip to content

2231 - backend for postprocessing (AsDiscrete, Activations Label2contour) #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 11 commits into from
Nov 4, 2021
Merged

2231 - backend for postprocessing (AsDiscrete, Activations Label2contour) #3254

wyli merged 11 commits into from
Nov 4, 2021

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 3, 2021 •
edited
Loading

part of #2231

Description

adds backend for label2contour postprocessing as well as (AsDiscrete, Activations Label2contour).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review November 4, 2021 00:26
@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/black

wyli added 8 commits November 4, 2021 10:17
@wyli
fixes docstring typos
134d8b4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
label to contour
fafff9c 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes dtype
c38e4ec 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
tests
149d9c4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
docstring
bcb3f3f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update filtering
408fce8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes backends
d8bceb3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds tests
b7dce46 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update postprocessing steps
004db5f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 2231 - backend for Label2contour 2231 - backend for postprocessing (AsDiscrete, Activations Label2contour) Nov 4, 2021
Nic-Ma
Nic-Ma approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
It looks good to me except for some minor comments inline.

Thanks.

wyli added 2 commits November 4, 2021 14:09
@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/black

@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented Nov 4, 2021

/build

@wyli wyli enabled auto-merge (squash) November 4, 2021 17:14
@wyli wyli disabled auto-merge November 4, 2021 19:52
@wyli wyli merged commit 6d2c1dc into Project-MONAI:dev Nov 4, 2021
@wyli wyli deleted the label2contour branch November 4, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyli @Nic-Ma