3253 Fix the spatial shape issue in NumpyReader and add channel dim #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
changed the title
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Member
|
I asked @danieltudosiu to have a look at this which relates to an issue of his. |
Contributor
Author
|
Hi @danieltudosiu , Could you please help review the PR or download it to verify locally? Thanks in advance. |
Contributor
Author
|
/build |
Contributor
Author
|
/integration-test |
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
Contributor
Author
|
Hi @ericspod , Do you have any comments that I need to address first? Thanks in advance. |
Contributor
|
Hi Nick, Having a look at it now. Should hear from me in about 30min max. Cheers! |
Contributor
Author
|
/build |
Contributor
|
Yeap, it is good. |
wyli
reviewed
Nov 5, 2021
wyli
approved these changes
Nov 6, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3253 .
Description
This PR fixed the spatial shape issue in
NumpyReaderand addedchannel_dim.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.