Update spatial_shape for WSIReader

[bhashemian]

Fixes #3256

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).

[Nic-Ma]

/build

[Nic-Ma]

Hi @drbeh ,

Is there any unit test to cover this spatial_shape property?

Thanks.

[bhashemian]

Hi @drbeh ,

Is there any unit test to cover this spatial_shape property?

Thanks.

@Nic-Ma, it is not part of the functionality of WSIReader and I am not sure how it is being used in the rest of MONAI. Do we have any documentation on this? so that I know what type of unit test it requires. Thanks

[wyli]

Hi @drbeh ,
Is there any unit test to cover this spatial_shape property?
Thanks.

@Nic-Ma, it is not part of the functionality of WSIReader and I am not sure how it is being used in the rest of MONAI. Do we have any documentation on this? so that I know what type of unit test it requires. Thanks

If we don't know how it is being used and how to verify this feature, why do we create and merge this PR?

[bhashemian]

You're right @wyli! But it was an obvious bug to fix. I don't know how and why you are using it but I only know an instance that it failed. #3256
I will make a unit test out of it but it's better to have a concrete unit test for all elements of these dictionaries that are being passed.

[bhashemian]

@wyli @Nic-Ma, I added a new test for WSIReader that covers the fixed issue here. https://github.com/Project-MONAI/MONAI/pull/3261/files