Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 5, 2021

Fixes #3263 .

Description

This PR fixed the issue that cuCIM can't find a suitable handler.
The root cause is that: this PR #3006 changed the URL of test data, then can't parse the image type from URL, and latest cuCIM added check for image type.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 5, 2021

I tested locally, all tests passed.

Thanks.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fixes!

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 5, 2021 10:54
@Nic-Ma Nic-Ma merged commit 856237e into Project-MONAI:dev Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly tests error: test_masked_inference_wsi_dataset

2 participants