3251 Add dependency check in WSIReader #3312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Nic-Ma
changed the title
Nic-Ma
requested review from
bhashemian,
ericspod,
rijobro,
wyli and
yiheng-wang-nv
yiheng-wang-nv
approved these changes
Nov 11, 2021
wyli
reviewed
Nov 11, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
approved these changes
Nov 11, 2021
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Contributor
Author
|
/build |
bhashemian
added a commit
that referenced
this pull request
Nov 16, 2021
* 3251 Add dependency check in WSIReader (#3312) * [DLMED] add dep check Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix typo Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Signed-off-by: myron <amyronenko@nvidia.com> * [DLMED] MILmodel PR Signed-off-by: myron <amyronenko@nvidia.com> * small updates Signed-off-by: myron <amyronenko@nvidia.com> * fix jit issues Signed-off-by: myron <amyronenko@nvidia.com> * jit fix attempt Signed-off-by: myron <amyronenko@nvidia.com> * removing Enum Signed-off-by: myron <amyronenko@nvidia.com> Co-authored-by: Nic Ma <nma@nvidia.com> Co-authored-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3251 .
Description
This PR is follow up of #3251 to add the dependency check in WSIReader.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.