Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Nov 16, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3347

Description

fixes the issue with iterdir() when root_dir is a relative path

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 16, 2021

/black
/integration-test

@wyli
Copy link
Contributor Author

wyli commented Nov 16, 2021

/build

@wyli wyli closed this Nov 16, 2021
@wyli wyli deleted the 3347-update-datasets branch November 16, 2021 14:29
@wyli wyli restored the 3347-update-datasets branch November 16, 2021 14:29
@wyli wyli reopened this Nov 16, 2021
@wyli wyli marked this pull request as ready for review November 16, 2021 17:56
@wyli wyli requested review from Nic-Ma, ericspod and rijobro November 16, 2021 17:56
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 16, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Nov 17, 2021

/build

@wyli wyli enabled auto-merge (squash) November 17, 2021 07:32
@wyli wyli merged commit b86d751 into Project-MONAI:dev Nov 17, 2021
@wyli wyli deleted the 3347-update-datasets branch April 27, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notebook tests error: ./2d_registration/registration_mednist.ipynb

2 participants