Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 19, 2021

Fixes #3368 .

Description

This PR added frame_dim to specify the dim as frames of visualization.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 19, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 19, 2021

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli November 19, 2021 15:37
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 19, 2021

I also tested the feature in PR: Project-MONAI/tutorials#448.

Thanks.

@wyli
Copy link
Contributor

wyli commented Nov 19, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 19, 2021

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 19, 2021 23:35
@wyli
Copy link
Contributor

wyli commented Nov 20, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 20, 2021

/build

@Nic-Ma Nic-Ma merged commit d0e72fb into Project-MONAI:dev Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add frame_dim to the matshow3d utility

3 participants