Skip to content

adds dints blocks #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 10 commits into from
Nov 19, 2021
Merged

adds dints blocks #3372

wyli merged 10 commits into from
Nov 19, 2021
+469 −0

Conversation

@dongyang0122
Copy link
Collaborator

@dongyang0122 dongyang0122 commented Nov 19, 2021 •
edited by wyli
Loading

part of #3103

Description

Adding operations and blocks which are required by DiNTS algorithm.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@dongyang0122 dongyang0122 requested review from Nic-Ma and wyli November 19, 2021 17:46
wyli added 7 commits November 19, 2021 17:51
@wyli
adds dints blocks
0134abf 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
docstring updates
79276fc 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update to use sequential
96dbb9c 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update tests
15c7deb 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes tests
a1859b6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update tests
500da75 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments
dc4409e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title [WIP] adds dints blocks adds dints blocks Nov 19, 2021
dongyang0122
dongyang0122 commented Nov 19, 2021
View reviewed changes
Copy link
Collaborator Author

@dongyang0122 dongyang0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wyli
Copy link
Contributor

wyli commented Nov 19, 2021

/build

dongy and others added 3 commits November 19, 2021 22:43
@wyli
update scripts
bb4a597 
Signed-off-by: dongy <dongy@nvidia.com>
@wyli
temp remote dints import
9cca0f8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge branch 'dev' into dints-block
9c2e73e
@wyli
Copy link
Contributor

wyli commented Nov 19, 2021

/build

@wyli wyli enabled auto-merge (squash) November 19, 2021 22:46
@wyli wyli merged commit 73d9afa into Project-MONAI:dev Nov 19, 2021
@wyli wyli deleted the dints-block branch November 19, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dongyang0122 @wyli