Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 23, 2020

Hi All,

This PR is to implement a basic checkpoint event handler for our MVP example only.
Totally based on Ignite APIs.
Could you please help review it when you are available?
Thanks in advance.

@Nic-Ma Nic-Ma changed the title 5 checkpoint event handler 5 (MVP)checkpoint event handler Jan 23, 2020
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 23, 2020

HI @ericspod ,

BTW, I totally understand that Jupyter Notebook can provide better user experience, especially for training steps, but I found that it's not very clear to review diffs if we modify notebook content.
So can we also add some python examples in later sprints?
Just like Ignite examples, it will be more clear to review and run locally.
And keep several beautiful Jupyter Notebooks for tutorials?
Thanks.

@ericspod
Copy link
Member

This changed file was removed in the main branch so we perhaps we defer doing anything with that example for now.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 23, 2020

This changed file was removed in the main branch so we perhaps we defer doing anything with that example for now.

Hi @ericspod ,

I think this PR is 1 commit ahead of the master branch on the example code.
Do you mean you are doing some other PR that removed this example?
Thanks.

@ericspod
Copy link
Member

Ah yes it was different version of this file that was moved.

@ericspod ericspod merged commit 5550925 into master Jan 23, 2020
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 23, 2020

Ah yes it was different version of this file that was moved.

Hi @ericspod ,

Thanks for your review and approval!
I think we are ready for the demo of this MVP, right?
Maybe you can help show it at next sprint meeting.
Thanks.

@wyli wyli deleted the 5-(MVP)checkpoint-event-handler branch May 21, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants