4166 fix bundle download test issue #4169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
ericspod
approved these changes
Apr 25, 2022
Contributor
|
/black |
Contributor
|
/build |
wyli
added a commit
that referenced
this pull request
Apr 26, 2022
* 4095 Add bundle download (#4114) * draft download Signed-off-by: Yiheng Wang <vennw@nvidia.com> * update bundle download Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add url and load Signed-off-by: Yiheng Wang <vennw@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * rename args and remove a few places Signed-off-by: Yiheng Wang <vennw@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix flake8 issue Signed-off-by: Yiheng Wang <vennw@nvidia.com> * enhance with reviews Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add instantiate for load Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fix black error Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add unittest Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add load to docs Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add skip Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add schemaerror Signed-off-by: Yiheng Wang <vennw@nvidia.com> * fix partial places Signed-off-by: Yiheng Wang <vennw@nvidia.com> * download zip bundle Signed-off-by: Yiheng Wang <vennw@nvidia.com> * [DLMED] restore Exception for test Signed-off-by: Nic Ma <nma@nvidia.com> * update ts features Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add config_files test case Signed-off-by: Yiheng Wang <vennw@nvidia.com> * enhance docstring example for args_file Signed-off-by: Yiheng Wang <vennw@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nic Ma <nma@nvidia.com> * Disable pylint error and fix CI tests of new tifffile (#4162) * workaround Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix tifffile issue Signed-off-by: Nic Ma <nma@nvidia.com> * Fixed an error in DiNTS model implementation and enabled act and norm layer options (#4157) * fixed a bug Signed-off-by: dongy <dongy@nvidia.com> * autofix Signed-off-by: dongy <dongy@nvidia.com> * update test case Signed-off-by: dongy <dongy@nvidia.com> Co-authored-by: dongy <dongy@nvidia.com> * Split transform (#4153) * Redesign whole slide image reading (#4107) * Redesign BaseWSIReader, WSIReader, CuCIMWSIReader Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittests for WSIReader Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add image mode for output validation Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update references to new WSIReader Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove legacy WSIReader Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update unittests Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * sort imports Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Clean up imports Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docstrings Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docs and docstrings Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix a typo Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove redundant checking Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update read and other methods Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update wsireader to support multi image and update docstrings Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Make workaround for CuImage objects Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittests for multi image reading Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update a note about cucim Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update type hints and docstrings Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Implement Split transform Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittests Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update formatting Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Implement SplitDict Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add unittests for SplitDict Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Remove images from docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Address all comments Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add example and size check Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Update docs Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Revert references to new wsireader Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * Add missing comma Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> * fix bundle download test issue (#4169) Signed-off-by: Yiheng Wang <vennw@nvidia.com> * 4094 Enhance `ckpt_export` to save config files (#4159) * [DLMED] enhance checkpoint export Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * Move RGB/RGBA checks to base class (#4171) Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com> Co-authored-by: Nic Ma <nma@nvidia.com> * [CICD] To support temp dgx runner (#4175) * Support new temp dgx runner Signed-off-by: Peixin Li <pxli@nyu.edu> * atol 1e-5 Signed-off-by: Wenqi Li <wenqil@nvidia.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com> * Test fix for AMP kwargs (#4178) Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk> Co-authored-by: Yiheng Wang <68361391+yiheng-wang-nv@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nic Ma <nma@nvidia.com> Co-authored-by: dongyang0122 <don.yang.mech@gmail.com> Co-authored-by: dongy <dongy@nvidia.com> Co-authored-by: Behrooz <3968947+drbeh@users.noreply.github.com> Co-authored-by: Peixin <pxli@nyu.edu> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #4166
Description
The root cause of the issue is that the created TorchScript module for unit test is created by torch==1.12.0, and may break in old torch versions. It is reasonable since Pytorch is not forward compatible.
I updated the test data in https://github.com/Project-MONAI/MONAI-extra-test-data/releases/tag/0.8.1 and the new ts module has been created by torch==1.7.1, and an elder torch version will skip the corresponding test case.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.