PR to demonstrate that CI jobs work on gitlab.com w/ GPU runners. Please comment. Thank you. #47
Conversation
|
Please review and verify if details of two checks can be viewed. I am pretty sure the first one works without any issue. The second one, from gitlab.com, requires confirmation. |
|
@ericspod @atbenmurray @wyli can you review this PR? This allow all contributors to see detailed integration tests. Our runner machine has 2+ GPUs |
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks! it looks good and I only have two minor issues:
- what happens to the GPU runner if we have concurrent push/PR events triggered?
- is the Jenkinsfile in this PR unused? (please remove if that's the case)
|
There is a queue in gitlab for all CI jobs. So when there are more than one CI jobs with the same 'tag,' currently we only have 'test' and one runner handles that, jobs will be queued. I will remove that Jenkinsfile. But this PR is not supposed to be merged. It's to demonstrate the CI jobs work in this configuration. |
IsaacYangSLA
changed the title
Include integration tests to see if GPU runner works.
IsaacYangSLA
force-pushed
the
test_ci_please_ignore
branch
from
a3bc9c8 to
f517ea1
Compare
|
changes included in #36 |
This is to verify if all CI tasks work as expected. Please don't merge it. Will close it once everything is verified.