2948 - regex pruning metadata keys #4819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
KumoLiu
approved these changes
Aug 3, 2022
Nic-Ma
approved these changes
Aug 3, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me, put minor comments inline.
Thanks.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
2948-filter-metadata
branch
from
ce8b67b to
dcc8a79
Compare
Contributor
Author
|
/build |
rijobro
reviewed
Aug 3, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
|
/build |
rijobro
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #2948
Description
adds API to prune metadata keys when loading
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.