Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Aug 8, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #233

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro August 8, 2022 12:11
wyli and others added 4 commits August 8, 2022 16:12
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review August 9, 2022 20:46
@wyli wyli requested a review from ericspod August 9, 2022 21:40
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Put minor comments inline.

Thanks.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Aug 11, 2022

/build

@wyli wyli enabled auto-merge (squash) August 11, 2022 10:31
@wyli wyli merged commit b1ccd02 into Project-MONAI:dev Aug 11, 2022
@wyli wyli deleted the bc-policy branch August 11, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set up an explicit backward compatibility policy

3 participants