-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Sobel Gradients Operator #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sobel Gradients Operator #5015
Conversation
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
KumoLiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, thanks!
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
|
thanks, I thought sobel kernel is always 3x3, why is there a size parameter, and it's unclear to me what sobel gradient is...perhaps a reference here? |
You are right, Sobel kernels are 3x3 but they can be generalized to a larger kernel size with different approaches. You can find a nice writeup on how to derive larger size kernels following the same property of 3x3 Sobel kernels: https://stackoverflow.com/a/41065243 Following the original implementation of HoVerNet, we are going to use 5x5 Sobel kernels in HoVerNet pipeline, and they have implemented kernels similar to this PR. Here is their implementation: |
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
|
/build |
Fixes #4997
Description
Implements Sobel gradients operators for a given size of kernel.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.