Skip to content

Conversation

@bhashemian
Copy link
Member

@bhashemian bhashemian commented Sep 8, 2022

Fixes #4955

Description

This PR makes GridPatch, GridPatchd, RandGridPatch and RandGridPatchd to create outputs as MetaTensors and return them as a single MetaTensor with is_batch=True.

It also makes get_default_affine() a static method, similar to get_default_meta(), to be able to it in other places.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

bhashemian and others added 14 commits September 6, 2022 17:41
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian marked this pull request as ready for review September 8, 2022 17:11
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian requested a review from Nic-Ma September 8, 2022 17:45
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@Nic-Ma Nic-Ma requested review from KumoLiu and wyli September 9, 2022 02:51
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@wyli
Copy link
Contributor

wyli commented Sep 9, 2022

/build

@wyli wyli enabled auto-merge (squash) September 9, 2022 19:34
@wyli wyli merged commit 59aeab0 into Project-MONAI:dev Sep 9, 2022
@bhashemian bhashemian deleted the metatensor-gridpatch branch September 9, 2022 22:56
atbenmurray added a commit that referenced this pull request Oct 28, 2022
Signed-off-by: Ben Murray <ben.murray@gmail.com>
atbenmurray added a commit that referenced this pull request Oct 30, 2022
Signed-off-by: Ben Murray <ben.murray@gmail.com>
atbenmurray added a commit that referenced this pull request Oct 30, 2022
Signed-off-by: Ben Murray <ben.murray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetaTensor support for GridPatch and RandGridPatchtransform

4 participants