Update SplitDimd to output lists
#5115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
2 tasks
Member
Author
KumoLiu
previously approved these changes
Sep 13, 2022
Contributor
Contributor
|
Closing, there is no code change in this pr. |
KumoLiu
reviewed
Sep 13, 2022
| dimension will be squeezed. | ||
| update_meta: if `True`, copy `[key]_meta_dict` for each output and update affine to | ||
| reflect the cropped image | ||
| list_output: it `True`, the output will be a list of dictionaries with the same keys as original. |
Contributor
There was a problem hiding this comment.
Hi @drbeh, if list_output is True, it will return a list of dictionaries in your design. Do we need just one dictionary with orginal key and a list of data?
Member
Author
There was a problem hiding this comment.
Hi @KumoLiu, we want to have a list of dictionaries all with the same keys, so the transforms are being applied individually on each of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5109
Description
Updates
SplitDimdto have the option of outputting a list of dictionaries.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.