Implement FlattenSubKeysd
#5554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
A use case can be found here for Project-MONAI/tutorials#1055 |
Member
Author
myron
reviewed
Nov 22, 2022
Collaborator
myron
left a comment
myron
left a comment
There was a problem hiding this comment.
Hi @drbeh , it seems good to me, but the name PromoteChildItemsd() is not very intuitive. You can consider calling it
MergeSubKeys(sub_keys=...) or FlattenSubKeys(sub_keys=..). And if sub_keys is not provided, merge all of them.
but this is minor, should not a be stopper for this issue..
Contributor
|
agree with @myron, I think |
Member
Author
wyli
approved these changes
Nov 23, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks good to me, please fix the typos I'll merge this
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
bhashemian
force-pushed
the
promote-child-itemd
branch
from
674f15d to
3abcb11
Compare
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Contributor
|
/build |
wyli
pushed a commit
to bhashemian/MONAI
that referenced
this pull request
Nov 23, 2022
Fixes Project-MONAI#5553 ### Description Promote specified children of specified items to the level of item. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [x] New tests added to cover the changes. - [x] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5553
Description
Promote specified children of specified items to the level of item.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.