Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jun 15, 2020

Fixes #568 .

Description

This PR implemented MedNIST dataset to download and load MedNIST dataset.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 15, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 16, 2020

/black

@Nic-Ma Nic-Ma changed the title [WIP] 568 add MedNIST dataset with download 568 add MedNIST dataset with download Jun 16, 2020
@Nic-Ma Nic-Ma requested review from atbenmurray, ericspod and wyli June 16, 2020 08:45
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I put some minor comments inline

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 16, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 16, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 16, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 17, 2020

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 17, 2020

Hi @wyli ,

Thanks for your review, I updated according to your comments.
Could you please help review it again?
Thanks.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Nic-Ma! I'll try to update the research demo to use this new downloading interface.
may add skip_if_quick for some slow downloading tests.

@Nic-Ma Nic-Ma merged commit afedafd into Project-MONAI:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MedNIST dataset

3 participants