Skip to content

Conversation

@rijobro
Copy link
Contributor

@rijobro rijobro commented Jan 17, 2023

Fixes #5862.

Description

if untyped_storage() is present (pytorch 2) use it, else use storage().

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested a review from wyli January 17, 2023 14:04
@wyli
Copy link
Contributor

wyli commented Jan 17, 2023

thanks, if the distributed test cases here https://github.com/Project-MONAI/MONAI/actions/runs/3939998267/jobs/6740545960 work fine I'll merge this PR

@wyli
Copy link
Contributor

wyli commented Jan 17, 2023

/build

@wyli wyli enabled auto-merge (squash) January 17, 2023 19:40
@wyli wyli merged commit 79b8b0c into Project-MONAI:dev Jan 17, 2023
@rijobro rijobro deleted the untyped_storage branch January 18, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pytorch 2: TypedStorage is deprecated

2 participants