Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Feb 14, 2023

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #5652

Description

by default random_size=True is somewhat unexpected

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from KumoLiu, Nic-Ma and ericspod February 14, 2023 11:43
@wyli wyli marked this pull request as ready for review February 14, 2023 11:45
@wyli wyli requested a review from yiheng-wang-nv February 14, 2023 12:02
@wyli
Copy link
Contributor Author

wyli commented Feb 14, 2023

/build

@wyli wyli enabled auto-merge (squash) February 14, 2023 12:50
@wyli wyli merged commit f6c6413 into Project-MONAI:dev Feb 14, 2023
@wyli wyli deleted the 5652-random-size branch February 14, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

random_size defaulting to False in RandSpatialCropd

2 participants