Skip to content

Conversation

@skinan
Copy link
Contributor

@skinan skinan commented Mar 21, 2023

Issue: fixes #6148
Previous Pull-request: #6013

@wyli, please re-run the tests, and check if the fixes work now.

@wyli
Copy link
Contributor

wyli commented Mar 21, 2023

sure thanks, I'm checking it now

@wyli
Copy link
Contributor

wyli commented Mar 21, 2023

some issues .. https://github.com/Project-MONAI/MONAI/actions/runs/4479724954/jobs/7874047823

======================================================================
ERROR: test_task_init (tests.test_handler_clearml_stats.TestHandlerClearMLStatsHandler)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/MONAI/MONAI/tests/test_handler_clearml_stats.py", line 36, in test_task_init
    with open(get_active_config_file()) as old_config:
TypeError: expected str, bytes or os.PathLike object, not NoneType

======================================================================
ERROR: test_task_init (tests.test_handler_clearml_image.TestHandlerClearMLImageHandler)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/MONAI/MONAI/tests/test_handler_clearml_image.py", line 36, in test_task_init
    with open(get_active_config_file()) as old_config:
TypeError: expected str, bytes or os.PathLike object, not NoneType

----------------------------------------------------------------------

you can consider this config to reproduce it https://github.com/Project-MONAI/MONAI/actions/runs/4479924665/workflow

skinan added 2 commits March 21, 2023 14:09
Signed-off-by: skinan <sakib.khaninan@gmail.com>
@skinan
Copy link
Contributor Author

skinan commented Mar 21, 2023

@wyli , I have fixed it and commited.

@wyli
Copy link
Contributor

wyli commented Mar 21, 2023

/build

@wyli
Copy link
Contributor

wyli commented Mar 21, 2023

the warnings are ok, right?

ClearML Task: created new task id=offline-747fe41447d847dda7aa17717fa7278c
2023-03-21 14:17:09,122 - clearml.Task - INFO - No repository found, storing script code instead
2023-03-21 14:17:09,128 - clearml.Repository Detection - WARNING - Failed auto-generating package requirements: too many values to unpack (expected 2)
.
ClearML running in offline mode, session stored in /github/home/.clearml/cache/offline/offline-747fe41447d847dda7aa17717fa7278c
ClearML Task: Offline session stored in /github/home/.clearml/cache/offline/offline-747fe41447d847dda7aa17717fa7278c.zip
----------------------------------------------------------------------
Ran 1 test in 0.346s

OK
ClearML Task: created new task id=offline-72bcb392e3324d6e9e34b9cbd542a7e1
2023-03-21 14:17:14,875 - clearml.Task - INFO - No repository found, storing script code instead
2023-03-21 14:17:14,881 - clearml.Repository Detection - WARNING - Failed auto-generating package requirements: too many values to unpack (expected 2)
.
----------------------------------------------------------------------
Ran 1 test in 0.339s

will the end users need to create the config as well?

"\nsdk.development.vcs_repo_detect_async: false\nsdk.development.report_use_subprocess: false\n"

@skinan
Copy link
Contributor Author

skinan commented Mar 21, 2023

@wyli , the warnings are ok for right now. It's set this way just for testing purposes. No, it won't be needed for the end users. It currently runs offline. So, we modified things in this case.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli enabled auto-merge (squash) March 21, 2023 14:36
@wyli wyli merged commit d57bff6 into Project-MONAI:dev Mar 21, 2023
jak0bw pushed a commit to jak0bw/MONAI that referenced this pull request Mar 28, 2023
**Issue:** fixes Project-MONAI#6148
**Previous Pull-request:**
Project-MONAI#6013

---------

Signed-off-by: skinan <sakib.khaninan@gmail.com>
jak0bw pushed a commit to jak0bw/MONAI that referenced this pull request Mar 28, 2023
**Issue:** fixes Project-MONAI#6148
**Previous Pull-request:**
Project-MONAI#6013

---------

Signed-off-by: skinan <sakib.khaninan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_handler_clearml_image cannot finish

3 participants