[WIP] add FLStatsHandler
#6220
Closed
[WIP] add FLStatsHandler
#6220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
6 tasks
Signed-off-by: KumoLiu <yunl@nvidia.com>
Contributor
Author
|
Hi @Nic-Ma @wyli @holgerroth @YuanTingHsieh, could you please help review it first. Not sure if this workaround is acceptable, if so then I could add unittest. I have tested it locally with this example in NVFlare repo. Thanks in advance! |
Nic-Ma
reviewed
Mar 22, 2023
Comment on lines
+38
to
+40
| class FLStatsHandler: | ||
| """ | ||
| FLStatsHandler defines a set of Ignite Event-handlers for all the NVFlare ``AnalyticsSender`` logics. |
Collaborator
There was a problem hiding this comment.
Just from a naming point of view, do we want this to be called FLStatsHandler or NVFlareStatsHandler?
Signed-off-by: KumoLiu <yunl@nvidia.com>
Contributor
Author
|
Update: Waiting for @chesterxgchen and @holgerroth to discuss a proposal. |
6 tasks
Contributor
Author
|
The changes in this PR have been included in NVIDIA/NVFlare#1925. |
7 tasks
wyli
pushed a commit
that referenced
this pull request
Sep 13, 2023
PR #6220 was closed and NVFlareStatsHandler has now been implemented in NVFlare in NVIDIA/NVFlare#1925. However, there is still the piece in MonaiAlgo to attach the stats_sender in initialize, so this PR adds that missing piece. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Kevin <kevlu@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
add
FLStatsHandlerfor NVFlare.It mainly call
_addinAnalyticsSender.https://github.com/NVIDIA/NVFlare/blob/b0de532fc2f65de30eb8af728561bab33fdaf076/nvflare/app_common/widgets/streaming.py#L97
Since
AnalyticsSendercan only send toFLStatsHandlerafter instantiated, I add it to ignite.engine.state as a workaround.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.