support GPU tensor for GridPatch and GridPatchDataset
#6246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `GridPatch`, `GridPatchd`, `RandGridPatch` and `RandGridPatchd` * `GridPatchDataset`, `PatchIter`, `PatchIterd` and `iter_patch`
for more information, see https://pre-commit.ci
wyli
reviewed
Mar 27, 2023
Contributor
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Contributor
Author
|
By checking the tests in CI, it seems |
Contributor
thanks, let me skip the tests for this new feature for torch<1.11... |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
there are still some typing issues, I think you can debug with |
DCO Remediation Commit for Qingpeng Li <qingpeng9802@gmail.com> I, Qingpeng Li <qingpeng9802@gmail.com>, hereby add my Signed-off-by to this commit: 4d178e2 Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
for more information, see https://pre-commit.ci
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Qingpeng Li <qingpeng9802@gmail.com>
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
Contributor
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6245 .
Description
support GPU tensor for
GridPatch,GridPatchd,RandGridPatchandRandGridPatchdGridPatchDataset,PatchIter,PatchIterdanditer_patchChanges
GridPatch,GridPatchDatasetand their siblings need to copy GPU tensor to numpy array (or not support GPU tensor) in their pipeline. This PR enables them to support end-to-end GPU operations.pad_ndis used heavily, its robustness is improved. Some strange behavior introduced byPaduses numpy though pytorch backend is available #6066 is fixed.GridPatch,GridPatchwithpin_memory=Truesignificant slow-down in following epochs #6082 might be fixed by this PR?RandGridPatch's mode defaults toNone(consistent with docs)Need to Notice
PatchIter,PatchIterdanditer_patchare kept asNumpyPadMode.WRAP. However,GridPatchdefaults toNone. (might be inconsistent?)Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.