Skip to content

Conversation

@binliunls
Copy link
Contributor

@binliunls binliunls commented Apr 27, 2023

Fixes #6415 .
(also fixes #6449)

Description

Fix the mlflow handler bug. When running a bundle with MLFLowHandler back to back without assigning the run name , the later run info will be recorded into the former run, although the former run is finished. This PR checks the status of runs and filters the finished ones.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

binliunls and others added 7 commits April 27, 2023 10:12
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
Signed-off-by: binliu <binliu@nvidia.com>
@binliunls binliunls changed the title [WIP]6415-fix-mlflow-handler-run-bug 6415-fix-mlflow-handler-run-bug Apr 28, 2023
@binliunls binliunls marked this pull request as ready for review April 28, 2023 07:39
@binliunls binliunls requested a review from Nic-Ma April 28, 2023 07:39
binliunls and others added 2 commits April 28, 2023 07:51
Signed-off-by: binliu <binliu@nvidia.com>
…ler-bug

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Apr 29, 2023

/build

@wyli wyli enabled auto-merge (squash) April 29, 2023 08:44
@wyli wyli merged commit d29914d into Project-MONAI:dev Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_move_bundle_gen_folder MLflow handler get wrong when running two run without name

3 participants