-
Notifications
You must be signed in to change notification settings - Fork 1.4k
added yandex.disk support and test file #6667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wyli
merged 4 commits into
Project-MONAI:dev
from
blacky-i:6666-yandex-download-support
Jun 28, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright (c) MONAI Consortium | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import os | ||
| import tempfile | ||
| import unittest | ||
| from urllib.error import HTTPError | ||
|
|
||
| from monai.apps.utils import download_url | ||
|
|
||
| YANDEX_MODEL_URL = ( | ||
| "https://cloud-api.yandex.net/v1/disk/public/resources/download?" | ||
| "public_key=https%3A%2F%2Fdisk.yandex.ru%2Fd%2Fxs0gzlj2_irgWA" | ||
| ) | ||
| YANDEX_MODEL_FLAWED_URL = ( | ||
| "https://cloud-api.yandex.net/v1/disk/public/resources/download?" | ||
| "public_key=https%3A%2F%2Fdisk.yandex.ru%2Fd%2Fxs0gzlj2_irgWA-url-with-error" | ||
| ) | ||
|
|
||
|
|
||
| class TestDownloadUrlYandex(unittest.TestCase): | ||
| def test_verify(self): | ||
| with tempfile.TemporaryDirectory() as tempdir: | ||
| download_url(url=YANDEX_MODEL_URL, filepath=os.path.join(tempdir, "model.pt")) | ||
wyli marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| def test_verify_error(self): | ||
| with tempfile.TemporaryDirectory() as tempdir: | ||
| with self.assertRaises(HTTPError): | ||
| download_url(url=YANDEX_MODEL_FLAWED_URL, filepath=os.path.join(tempdir, "model.pt")) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test will run regularly by testing pipelines, do you think this URL and the file will be available all the time for those pipelines? @blacky-i (currently removed 7cb71a0)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two risks in this url:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it seems when there are concurrent downloadings from multiple jobs, it becomes unavailable, for example:
https://github.com/Project-MONAI/MONAI/actions/runs/5403919298/jobs/9817414158
anyway I think it's now skipped and is not a critical issue because it'll not impact the other downloading capability..