Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 18, 2023

Fixes #6668 .

Fix hard-coded up_kernel_size in ViTAutoEnc without changing the network architecture.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 3 commits July 18, 2023 13:32
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from Nic-Ma, finalelement and wyli July 18, 2023 05:42
KumoLiu added 2 commits July 18, 2023 13:54
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) July 18, 2023 07:19
@wyli
Copy link
Contributor

wyli commented Jul 18, 2023

/build

@wyli wyli merged commit a5dff5b into Project-MONAI:dev Jul 18, 2023
@KumoLiu KumoLiu deleted the vitautoenc branch July 18, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViTAutoEnc hard-codes output patch size to 4

2 participants