Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jul 22, 2023

Description

  • output file name extension to be consistent with self.fmt
  • improve logging messages when writing files
  • export file format may be spelt as 'yml' instead of 'yaml'

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli . It looks good to me.

@wyli
Copy link
Contributor Author

wyli commented Jul 22, 2023

/integration-test
/build

@wyli wyli enabled auto-merge (squash) July 22, 2023 15:27
@wyli wyli merged commit 644c9e5 into Project-MONAI:dev Jul 22, 2023
@wyli wyli deleted the improve-usability branch July 22, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants