Skip to content

fixes dice loss #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 2 commits into from
Feb 12, 2020
Merged

fixes dice loss #70

wyli merged 2 commits into from
Feb 12, 2020

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Feb 11, 2020

Description

fixes a bug and a few typos introduced by the previous refactoring #66
additional tests included.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@wyli wyli requested a review from ericspod February 11, 2020 09:54
ericspod
ericspod reviewed Feb 11, 2020
View reviewed changes
@wyli wyli requested a review from ericspod February 12, 2020 11:59
@wyli wyli merged commit 3e0fdc4 into master Feb 12, 2020
@wyli wyli deleted the fixes-dice-loss-typos branch February 28, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericspod ericspod ericspod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyli @ericspod