Skip to content

Fix unsuitable default value to bundle_root in ckpt_export #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wyli merged 5 commits into from
Oct 12, 2023
Merged

Fix unsuitable default value to bundle_root in ckpt_export #7124

wyli merged 5 commits into from
Oct 12, 2023

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 12, 2023

Fixes #7123

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#7123
cb2fd3b 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
e07b4e0 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review October 12, 2023 09:32
@KumoLiu KumoLiu requested review from Nic-Ma, ericspod and wyli October 12, 2023 09:32
@KumoLiu
address comments
b8a39b2 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
bcd0bdf 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli reviewed Oct 12, 2023
View reviewed changes
@KumoLiu @wyli
Update monai/bundle/scripts.py
258af69 
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@wyli
Copy link
Contributor

wyli commented Oct 12, 2023

/build

@wyli wyli enabled auto-merge (squash) October 12, 2023 10:20
@wyli wyli merged commit 865972f into Project-MONAI:dev Oct 12, 2023
@KumoLiu KumoLiu deleted the ckpt-export branch October 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsuitable default value to bundle_root in ckpt_export

2 participants

@KumoLiu @wyli