6676 port diffusion schedulers #7332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
… ensure the output from a sampling run did not change Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
Contributor
Author
|
I'm getting a mypy error that I'm struggling to fix for the ddim scheduler: monai/networks/schedulers/ddim.py:219:21: error: No overload variant of "to" of "_TensorBase" matches argument type "object" [call-overload]
monai/networks/schedulers/ddim.py:219:21: note: Possible overload variants:
monai/networks/schedulers/ddim.py:219:21: note: def to(self, dtype: dtype, non_blocking: bool = ..., copy: bool = ...) -> Tensor
monai/networks/schedulers/ddim.py:219:21: note: def to(self, device: Union[device, str, None] = ..., dtype: Optional[dtype] = ..., non_blocking: bool = ..., copy: bool = ...) -> Tensor
monai/networks/schedulers/ddim.py:219:21: note: def to(self, other: Tensor, non_blocking: bool = ..., copy: bool = ...) -> Tensorany ideas would be appreciated! |
Member
Line 218 may have to be |
Signed-off-by: Mark Graham <markgraham539@gmail.com>
KumoLiu
reviewed
Dec 28, 2023
11 tasks
Contributor
|
/build |
ericspod
reviewed
Jan 3, 2024
Member
|
I had a minor question but good to merge this otherwise. |
7 tasks
KumoLiu
pushed a commit
that referenced
this pull request
Jan 5, 2024
This is an update to PR #7332 - I addressed the comments but failed to push the changes before it was merged! Changes are very minor. ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mark Graham <markgraham539@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
marksgraham
added a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
Towards Project-MONAI#6676 . ### Description This adds some base classes for DDPM noise schedulers + three scheduler types. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mark Graham <markgraham539@gmail.com>
marksgraham
added a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
This is an update to PR Project-MONAI#7332 - I addressed the comments but failed to push the changes before it was merged! Changes are very minor. ### Description A few sentences describing the changes proposed in this pull request. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Mark Graham <markgraham539@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Mark Graham <markgraham539@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6676 .
Description
This adds some base classes for DDPM noise schedulers + three scheduler types.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.