Skip to content

Fix CUDA_VISIBLE_DEVICES setting ignored #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KumoLiu merged 4 commits into from
Jan 22, 2024
Merged

Fix CUDA_VISIBLE_DEVICES setting ignored #7408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f18096d
fix #7407
KumoLiu Jan 22, 2024
6e58881
add tests
KumoLiu Jan 22, 2024
0abd612
address comments
KumoLiu Jan 22, 2024
fa988df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions monai/metrics/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,6 @@
binary_erosion, _ = optional_import("scipy.ndimage.morphology", name="binary_erosion")
distance_transform_edt, _ = optional_import("scipy.ndimage.morphology", name="distance_transform_edt")
distance_transform_cdt, _ = optional_import("scipy.ndimage.morphology", name="distance_transform_cdt")
cucim_binary_erosion, has_cucim_binary_erosion = optional_import("cucim.skimage.morphology", name="binary_erosion")
cucim_distance_transform_edt, has_cucim_distance_transform_edt = optional_import(
"cucim.core.operations.morphology", name="distance_transform_edt"
)

__all__ = [
"ignore_background",
Expand Down Expand Up @@ -179,6 +175,8 @@ def get_mask_edges(
always_return_as_numpy: whether to a numpy array regardless of the input type.
If False, return the same type as inputs.
"""
# move in the funciton to avoid using all the GPUs
cucim_binary_erosion, has_cucim_binary_erosion = optional_import("cucim.skimage.morphology", name="binary_erosion")
if seg_pred.shape != seg_gt.shape:
raise ValueError(f"seg_pred and seg_gt should have same shapes, got {seg_pred.shape} and {seg_gt.shape}.")
converter: Any
Expand Down
7 changes: 7 additions & 0 deletions tests/test_set_visible_devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ def test_visible_devices(self):
)
self.assertEqual(num_gpus_before, num_gpus_after)

# test import monai won't affect setting CUDA_VISIBLE_DEVICES
num_gpus_after_monai = self.run_process_and_get_exit_code(
'python -c "import os; import torch; import monai; '
+ "os.environ['CUDA_VISIBLE_DEVICES'] = '0'; exit(torch.cuda.device_count())\""
)
self.assertEqual(num_gpus_after_monai, 1)


if __name__ == "__main__":
unittest.main()