Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Feb 21, 2024

Fixes #7013 #7478

Description

replace predict_from_raw_data with nnUNetPredictor in test_nnunetv2runner

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@ericspod
Copy link
Member

The change nnUNet that this fixes appears to be in version 2.2, we should specify somewhere that this version is needed now. I don't see where we've specified nnUNet as a dependency however.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 21, 2024

Hi @ericspod, we didn't add nnunetv2 as a dependency requirement, the error log is from daily ci in the blossom which fixed the nnunetv2 version to 2.1 as a workaround, but due to the recent update from nnunet team, It raises another error, so I update the nnUNetV2Runner to be compatible with the latest nnunet. Do you think if we need to mention the version in docstring or somewhere else?

@ericspod
Copy link
Member

Hi @ericspod, we didn't add nnunetv2 as a dependency requirement, the error log is from daily ci in the blossom which fixed the nnunetv2 version to 2.1 as a workaround, but due to the recent update from nnunet team, It raises another error, so I update the nnUNetV2Runner to be compatible with the latest nnunet. Do you think if we need to mention the version in docstring or somewhere else?

We don't mention the requirements for any of the things in the apps directory that may be different from what's mentioned in the requirements files. We should have readme files for these or some mention of requirements in the docs. For now we can add a comment about needing the 2.2 version.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 21, 2024

Mentioned it in the docstring for now.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 21, 2024

/build

@KumoLiu KumoLiu merged commit f4103c5 into Project-MONAI:dev Feb 22, 2024
@KumoLiu KumoLiu deleted the nnunetv2 branch February 22, 2024 02:29
juampatronics pushed a commit to juampatronics/MONAI that referenced this pull request Mar 25, 2024
Fixes Project-MONAI#7013 Project-MONAI#7478

### Description
replace `predict_from_raw_data` with `nnUNetPredictor` in
test_nnunetv2runner

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
Fixes Project-MONAI#7013 Project-MONAI#7478

### Description
replace `predict_from_raw_data` with `nnUNetPredictor` in
test_nnunetv2runner

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_nnunetv2runner

2 participants