Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Feb 23, 2024

Part of #7486

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@atbenmurray
Copy link
Contributor

@KumoLiu @vikashg @ericspod @Nic-Ma Can we set up a geometry branch for the time being? I think aspects of this geometry work are likely to change as we work through it, so we might want to keep it off dev until we have the full picture

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Feb 23, 2024

@KumoLiu @vikashg @ericspod @Nic-Ma Can we set up a geometry branch for the time being? I think aspects of this geometry work are likely to change as we work through it, so we might want to keep it off dev until we have the full picture

Sure, I can create one.

@KumoLiu KumoLiu self-assigned this Mar 1, 2024
@KumoLiu KumoLiu changed the base branch from dev to geometric March 1, 2024 09:17
Copy link
Contributor

@atbenmurray atbenmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go on the geometry branch.

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Apr 11, 2024

/build

@KumoLiu KumoLiu merged commit 00436d0 into Project-MONAI:geometric Apr 12, 2024
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request Apr 19, 2024
Part of Project-MONAI#7486


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants