Geometric transform -- Flip #7508
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
…o flip-geometric
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
vikashg
left a comment
vikashg
left a comment
There was a problem hiding this comment.
Hi @KumoLiu
The code looks good to me. However, it will be nice to maintain a Jupyter notebook where we can test it from a user perspective along with some sample data and annotations.
I went through the code and it looks compatible to me (although, I will admit I have a limited understanding of the lazy implementation).
So, if you can start a sample notebook along with the pull request it will be easier for me to review and test failures.
Same goes for the other pull request.
Thank you
Vikash
Yes, I didn't complete the lazy implementation yet.
Yes, can add one, and also, I added some unittests. |
|
|
||
|
|
||
| def flip(img, sp_axes, lazy, transform_info): | ||
| def flip_image(img, sp_axes, lazy, transform_info): |
There was a problem hiding this comment.
Same deal as with #7509. We should pull flip implementation out of flip_image and flip_geom.
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Fixes Project-MONAI#7703 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
This reverts commit 4abaa8e.
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
…to flip-geometric
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
3 participants
Part of #7486
Description
Geometric transform -- Flip
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.