Skip to content

Add version requirement for mlflow #7659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KumoLiu merged 2 commits into from
Apr 19, 2024
Merged

Add version requirement for mlflow #7659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91ab6ff
fix #7658
KumoLiu Apr 18, 2024
decf830
fix #7666
KumoLiu Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ sphinx-autodoc-typehints==1.11.1
pandas
einops
transformers<4.22; python_version <= '3.10' # https://github.com/Project-MONAI/MONAI/issues/5157
mlflow>=1.28.0
mlflow>=1.28.0, <=2.11.3
clearml>=1.10.0rc0
tensorboardX
imagecodecs; platform_system == "Linux" or platform_system == "Darwin"
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pandas
requests
einops
transformers>=4.36.0
mlflow>=1.28.0
mlflow>=1.28.0, <=2.11.3
clearml>=1.10.0rc0
matplotlib!=3.5.0
tensorboardX
Expand Down
4 changes: 2 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ all =
pandas
einops
transformers<4.22; python_version <= '3.10'
mlflow>=1.28.0
mlflow>=1.28.0, <=2.11.3
clearml>=1.10.0rc0
matplotlib
tensorboardX
Expand Down Expand Up @@ -125,7 +125,7 @@ einops =
transformers =
transformers<4.22; python_version <= '3.10'
mlflow =
mlflow
mlflow>=1.28.0, <=2.11.3
matplotlib =
matplotlib
clearml =
Expand Down
3 changes: 2 additions & 1 deletion tests/test_clip_intensity_percentiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from monai.transforms import ClipIntensityPercentiles
from monai.transforms.utils import soft_clip
from monai.transforms.utils_pytorch_numpy_unification import clip, percentile
from monai.utils.type_conversion import convert_to_tensor
from tests.utils import TEST_NDARRAYS, NumpyImageTestCase2D, NumpyImageTestCase3D, assert_allclose


Expand All @@ -29,7 +30,7 @@ def test_hard_clipping_two_sided(self, p):
im = p(self.imt)
result = hard_clipper(im)
lower, upper = percentile(im, (5, 95))
expected = clip(im, lower, upper)
expected = clip(convert_to_tensor(im), lower, upper)
assert_allclose(result, p(expected), type_test="tensor", rtol=1e-7, atol=0)

@parameterized.expand([[p] for p in TEST_NDARRAYS])
Expand Down
3 changes: 2 additions & 1 deletion tests/test_clip_intensity_percentilesd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from monai.transforms import ClipIntensityPercentilesd
from monai.transforms.utils import soft_clip
from monai.transforms.utils_pytorch_numpy_unification import clip, percentile
from monai.utils.type_conversion import convert_to_tensor
from tests.utils import TEST_NDARRAYS, NumpyImageTestCase2D, NumpyImageTestCase3D, assert_allclose


Expand All @@ -31,7 +32,7 @@ def test_hard_clipping_two_sided(self, p):
im = p(self.imt)
result = hard_clipper({key: im})
lower, upper = percentile(im, (5, 95))
expected = clip(im, lower, upper)
expected = clip(convert_to_tensor(im), lower, upper)
assert_allclose(result[key], p(expected), type_test="tensor", rtol=1e-7, atol=0)

@parameterized.expand([[p] for p in TEST_NDARRAYS])
Expand Down